Conversation
qarmin
force-pushed
the
flatpak_krokiet
branch
from
4d42f7e to
00932e4
Compare
qarmin
force-pushed
the
flatpak_krokiet
branch
from
7b6788f to
82db2a9
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds Flatpak support to Krokiet by implementing XDG portal-based trash functionality, addressing file deletion issues in sandboxed environments (Flatpak). It also consolidates per-tool settings for hard links and cache management into global settings, updates Slint to version 1.14.1, migrates error messages to i18n, and improves the video optimizer's CLI interface by using strongly-typed codec enums.
Changes:
- Implements XDG portal trash functionality for Linux Flatpak environments using
ashpdandtokio - Consolidates
hide_hard_linksanddelete_outdated_cache_entriessettings from per-tool to global settings - Updates application metadata files (metainfo, desktop) with corrected IDs and license information
- Migrates numerous error messages in core library to use fluent i18n translations
- Changes video optimizer CLI to use strongly-typed
VideoCodecenum instead of strings - Re-enables Android build checks in CI with
blake_purefeature
Reviewed changes
Copilot reviewed 64 out of 65 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| czkawka_core/src/common/mod.rs | Adds XDG portal trash implementation with tokio runtime management |
| czkawka_core/Cargo.toml | Adds ashpd and tokio dependencies for XDG portal support |
| krokiet/src/settings/model.rs | Consolidates hide_hard_links and delete_outdated_cache_entries to global settings |
| krokiet/ui/settings.slint | Updates UI to reflect consolidated global settings |
| krokiet/ui/translations.slint | Adds new translation strings for consolidated settings |
| krokiet/i18n/en/krokiet.ftl | Adds English translations for new UI strings |
| czkawka_core/i18n/en/czkawka_core.ftl | Adds extensive i18n strings for error messages |
| czkawka_cli/src/main.rs | Updates CLI to use set_hide_hard_links() method |
| czkawka_cli/src/commands.rs | Changes video codec parameters from String to VideoCodec enum |
| data/io.github.qarmin.krokiet.metainfo.xml | New metainfo file with corrected app ID and license |
| data/io.github.qarmin.krokiet.desktop | Updated desktop file comment (em dash to hyphen) |
| .github/workflows/linux.yml | Re-enables Android build check with blake_pure feature |
| Cargo.lock | Updates dependencies including slint 1.14.1, ashpd, tokio |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1197
Fixes #811
Fixes #1545
Fixes #1720 - updating to slint 1.15, which fixes crash, that happened there